Thrift API for Erlang
Greetings. I noticed a small inconvenience in the thrift_client Erlang module. call(Client, Function, Args) when is_pid(Client), is_atom(Function), is_list(Args) -> case gen_server:call(Client,...
View ArticleThrift API for Erlang
Created a ticket in jira: https://issues.apache.org/jira/browse/THRIFT-825 On Thu, Jul 22, 2010 at 11:35 AM, Dmitry Demeshchuk wrote: -- Best regards, Dmitry Demeshchuk -- Dmitry Demeshchuk
View ArticleThrift API for Erlang
Consider changing the various guards to: is_pid(Client) orelse is_atom(Client) Also, I think taking advantage of http://www.erlang.org/doc/man/gen_server.html#start_link-4 is a better bet for your...
View ArticleThrift API for Erlang
As I mentioned above, I could use not atom or pid: {'somenode@somehost', registered_pid_name} The main Erlang credo is "let it fail". Yes, I was thinking about it initially. But then I came with the...
View ArticleThrift API for Erlang
Oh sorry. Yeah, you're right, removing the guard should work then. I think making a backwards-incompatible change *or* adding an additional start/4 function that calls into the gen_server module to...
View ArticleThrift API for Erlang
It's not a good idea to use same function with the different sets of parameters, even if we separate them using type checks. The function interface should be transparent and clear for the programmer....
View Article